You have some bugs in your sale badge, If I have a variation product it would not display correctly (on variation, it should simply display 'Sale' ), solution, you should integrate everything into one function you can name it satine_elated_wc_sale

function satine_elated_woocommerce_sale_badge($product, $price, $sale_price){
        //print_r($sale_price);
        if($price > 0 && $sale_price !== 0 ) {
            return '-' . (100 - round(($sale_price * 100) / $price)) . '%';
        }else if ( !$product->has_child() && $sale_price === 0 ){
            return esc_html__('FREE', 'satine');
        }else{
            return esc_html__('SALE', 'satine');
        }
    }

the has_child is just there as an example.. but you need to use it I guess.

original function:

function satine_elated_woocommerce_sale_percentage($price, $sale_price){
        if($price > 0 ) {
            return '-' . (100 - round(($sale_price * 100) / $price)) . '%';
        }else{
            return esc_html__('SALE', 'satine');
        }
    }

You need to re-check this issue, simply create a variation product with a sale, and see if you can see the badge correctly on front page, category and tag pages.

On the front page it shows up, but not in category or tag pages.

The way it shows up on front page is the following: my regular price is $32, but my sale price is $30. so because this is a variation product and the sale is only on 1 of the variations, the correct way of displaying the badge would be to simply output "Sale". but instead it would just show "-100%". The reason it shows -100% is because he doesn't capture the actual sale price and takes the value from regular price, so he thinks the product is free of charge, aka - 100%..

Check this issue, it's a bug for sure, oh and I'm a developer myself.

You should incorporate this into your framework, it would be easier to handle it across all of your themes.

Robert

Out of curiosity is there a fix for this?  My client is using role-based pricing.  So the average user sees one price/discount but "wholesale" customers see a price that is 2/3 cheaper.  Yet the badge always displays "-100%" for all of the items for wholesale customers (this is for simple and variable products).  If there is a fix for this it would be great.  Even if it just said "Sale" that would be appreciated.